"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: gotwebd: use `listen on socket' syntax for UNIX sockets too
To:
Omar Polo <op@omarpolo.com>
Cc:
gameoftrees@openbsd.org
Date:
Mon, 2 Jan 2023 12:00:28 +0100

Download raw body.

Thread
On Mon, Jan 02, 2023 at 11:18:38AM +0100, Omar Polo wrote:
> Currently gotwebd.conf(5) provides two way to specify where to listen
> for incoming connections:
> 
>  - `listen on <addr>' for tcp sockets
>  - `unix_socket' + `unix_socket_name' for unix-domain sockets
> 
> with the difference being that `listen on <addr>' may be used to more
> than once and unix_socket/unix_socket_name can't (each setting
> overwrites the previous.)
> 
> Why don't unify the settings?
> 
> Diff below adds `listen on socket off' to disable listening on the
> unix-domain socket and `listen on socket <path>' to specify the path.
> Like the unix_socket* settings these can only specified once.
> 
> Does listening on multiple unix socket makes sense?  Should it handle
> that case too or just add a note in the manpage that `listen on socket
> <path>' should only be used once?

Sure, make sense.

> (I'm keeping the handling of unix_socket* in server context (but
> deleting the documentation) to provide some sort of backward
> compatibilty, to be deleted after the next release.  Maybe should I
> just delete them?)

Just delete them.
We don't need to provide backwards compatibility between releases yet.