"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Mark Jamsek <mark@jamsek.com>
Subject:
tog: fix dead store
To:
Game of Trees <gameoftrees@openbsd.org>
Date:
Wed, 11 Jan 2023 00:45:35 +1100

Download raw body.

Thread
  • Mark Jamsek:

    tog: fix dead store

As per the subject line, we already assign {first,last}_displayed_line
just above these assignments so they're redundant.

-----------------------------------------------
commit 7e9724066e5351714d0abd0937c39014e6f73910 (main)
from: Mark Jamsek <mark@jamsek.dev>
date: Tue Jan 10 13:41:14 2023 UTC
 
 tog: fix {first,last}_displayed_line dead store
 
 Both are already assigned just above in open_diff_view()
 
diff 910d235d362fb7951e997ce08e3dfb4b8cb24c5d 7e9724066e5351714d0abd0937c39014e6f73910
commit - 910d235d362fb7951e997ce08e3dfb4b8cb24c5d
commit + 7e9724066e5351714d0abd0937c39014e6f73910
blob - 1e45e74bb81aeea0621ba64c6624713e630ee084
blob + 3bf0246d75b75fc92ca14ca210759bab8aebcdc2
--- tog/tog.c
+++ tog/tog.c
@@ -5060,8 +5060,6 @@ open_diff_view(struct tog_view *view, struct got_objec
 		goto done;
 	}
 
-	s->first_displayed_line = 1;
-	s->last_displayed_line = view->nlines;
 	s->diff_context = diff_context;
 	s->ignore_whitespace = ignore_whitespace;
 	s->force_text_diff = force_text_diff;

-- 
Mark Jamsek <fnc.bsdbox.org>
GPG: F2FF 13DE 6A06 C471 CA80  E6E2 2930 DC66 86EE CF68