"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: two pack file creation fixes
To:
gameoftrees@openbsd.org
Date:
Thu, 26 Jan 2023 23:07:31 +0100

Download raw body.

Thread
On Thu, Jan 26, 2023 at 10:16:56PM +0100, Stefan Sperling wrote:
> @@ -1471,6 +1471,9 @@ enumeration_request(struct imsg *imsg, struct imsgbuf 
>  		}
>  
>  		if (got_object_idset_contains(idset, tree_id)) {
> +			err = send_tree_enumeration_done(ibuf);
> +			if (err)
> +				goto done;
>  			got_object_qid_free(qid);
>  			qid = NULL;
>  			continue;
> 

Actually, to avoid a leak on error here, we should free qid first
and then send the 'done' message. Fixed in my local commits.