return err--not NULL--in got.c:print_backup

From:: Mark Jamsek <mark@jamsek.com>
Subject:: return err--not NULL--in got.c:print_backup_ref()
To:: Game of Trees <gameoftrees@openbsd.org>
Date:: Tue, 31 Jan 2023 22:47:36 +1100

Download raw body.

Thread

2023-01-31 11:47 Mark Jamsek:
return err--not NULL--in got.c:print_backup_ref()
- 2023-01-31 12:36 Stefan Sperling:
  return err--not NULL--in got.c:print_backup_ref()

As per the subject, we mistakenly return NULL instead of err:

diff /home/mark/src/got
commit - 62690bf9e68f6eb15e42b568250ef7df2a86ff2a
path + /home/mark/src/got
blob - a864445f9768f13cbf1a6d075b92520f5154e9bf
file + got/got.c
--- got/got.c
+++ got/got.c
@@ -10746,7 +10746,7 @@ done:
 	if (yca_commit)
 		got_object_commit_close(yca_commit);
 
-	return NULL;
+	return err;
 }
 
 static const struct got_error *

-- 
Mark Jamsek <fnc.bsdbox.org>
GPG: F2FF 13DE 6A06 C471 CA80  E6E2 2930 DC66 86EE CF68

2023-01-31 11:47 Mark Jamsek:
return err--not NULL--in got.c:print_backup_ref()
- 2023-01-31 12:36 Stefan Sperling:
  return err--not NULL--in got.c:print_backup_ref()