"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Omar Polo <op@omarpolo.com>
Subject:
Re: gotd/gotadmin use 0444 for pack/idx
To:
Stefan Sperling <stsp@stsp.name>
Cc:
gameoftrees@openbsd.org
Date:
Wed, 01 Feb 2023 15:23:47 +0100

Download raw body.

Thread
shame on me for not testing the regress.  This causes when running on a TTY

[...]
==== cleanup ====
./cleanup.sh -q -r "/tmp"
override r--r--r--  op/wheel for /tmp/got-test-cleanup_missing_pack_file-2Y7fJ9tp/repo/.git/objects/pack/pack-143e0e01bb93980b62e8c6135bc7d4ebf0135aa4.pack?

which I guess warrants a -f

diff /tmp/got
commit - 146fcaf8ea62489866757c517391d93347314049
path + /tmp/got
blob - 06fe38880f4015429de2b40bbdae85ed128d5925
file + regress/cmdline/cleanup.sh
--- regress/cmdline/cleanup.sh
+++ regress/cmdline/cleanup.sh
@@ -291,7 +291,7 @@ test_cleanup_missing_pack_file() {
 
 	# Some freshly cloned Git repositories suffer from lonely pack index
 	# files. Remove the pack file we just wrote to simulate this issue.
-	rm $testroot/repo/.git/objects/pack/pack-$packname
+	rm -f $testroot/repo/.git/objects/pack/pack-$packname
 
 	# cleanup should now refuse to purge objects
 	gotadmin cleanup -a -q -r $testroot/repo > $testroot/stdout \