On Tue, Feb 07, 2023 at 12:08:40AM +1100, Mark Jamsek wrote:
> The gotd build appears to be broken at the moment:
> 
> ----8<--------
>   $ make server
>   ...
>   cc -O0 -g  -o gotctl gotctl.o error.o imsg.o pollfd.o sha1.o -lutil -lz -lm -levent
>   ld: error: undefined symbol: got_object_id_hex
>   >>> referenced by error.c:374 (/home/mark/src/got/gotctl/../lib/error.c:374)
>   >>>               error.o:(got_error_no_obj)
>   >>> referenced by error.c:391 (/home/mark/src/got/gotctl/../lib/error.c:391)
>   >>>               error.o:(got_error_checksum)
>   cc: error: linker command failed with exit code 1 (use -v to see invocation)
>   *** Error 1 in gotctl (<bsd.prog.mk>:126 'gotctl')
>   *** Error 2 in /home/mark/src/got (Makefile:49 'server')
> -------->8----
> 
> The below diff seems to produce a clean build, with both regress/cmdline
> and regress/gotd passing.

Indeed, thanks, please go ahead.

This reminds me that the regress builder script should also be
running the 'make server' target. I will look into this.