"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Mark Jamsek <mark@jamsek.com>
Subject:
possible gotd log typo
To:
Game of Trees <gameoftrees@openbsd.org>
Date:
Tue, 7 Feb 2023 16:10:48 +1100

Download raw body.

Thread
Currently, running:

  # gotd -f /etc/gotd.conf

produces the error report:

  gotd: : bad path "gotd": must be an absolute path

I'm not sure if the second colon is an unintentional result of a typo or
is indeed intended. If the former is the case, the following diff turns
the same error report (without any regress fallout) into:

  gotd: bad path "gotd": must be an absolute path

diff /home/mark/src/got
commit - c9003c52fc7f70dd988402560adcd22709e74800
path + /home/mark/src/got
blob - 5bb8770f6058679e049a234c6d8b4492640cfd7e
file + gotd/log.c
--- gotd/log.c
+++ gotd/log.c
@@ -166,9 +166,9 @@ vfatalc(int code, const char *emsg, va_list ap)
 		sep = "";
 	}
 	if (code)
-		logit(LOG_CRIT, "%s: %s%s", s, sep, strerror(code));
+		logit(LOG_CRIT, "%s%s%s", s, sep, strerror(code));
 	else
-		logit(LOG_CRIT, "%s%s", sep, s);
+		logit(LOG_CRIT, "%s", s);
 }
 
 void

-- 
Mark Jamsek <fnc.bsdbox.org>
GPG: F2FF 13DE 6A06 C471 CA80  E6E2 2930 DC66 86EE CF68