On 2023/02/23 13:39:21 +0100, Stefan Sperling <stsp@stsp.name> wrote:
> On Thu, Feb 23, 2023 at 11:48:27AM +0100, Omar Polo wrote:
> > I've partially misunderstood your suggestion.  Here's a better diff.
> > it completely retires got_parse_sha1() in favour of
> > got_parse_hash_digest, but keeps got_sha1_digest_to_str().  Will look
> > later how to drop that too in favour of a generic got_hash_digest_to_str().
> 
> Indeed, what you've done here is what I had in mind.
> This could have easily been done as a follow-up change, too, I didn't
> mean to block you on this.

not a problem at all!  I still have to rebase (and probably adjust
too) some commits anyway, and I prefer to fix issues like this before
getting stuff into the tree.

> Still ok by me.

Thanks!