"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Christian Weisgerber <naddy@mips.inka.de>
Subject:
Re: improve `got he' error reporting (and accept shortened ids)
To:
Omar Polo <op@omarpolo.com>
Cc:
gameoftrees@openbsd.org
Date:
Mon, 27 Feb 2023 15:35:38 +0100

Download raw body.

Thread
Omar Polo:

> -			err = got_object_resolve_id_str(&commit_id, repo, p);
> +			err = got_repo_match_object_id_prefix(&commit_id,
> +			    p, GOT_OBJ_TYPE_COMMIT, repo);
>  			if (err) {
>  				/* override error code */
> -				err = histedit_syntax_error(lineno);
> +				err = histedit_syntax_error(lineno,
> +				    "invalid object id");

Could you check for... GOT_ERR_AMBIGUOUS_ID, I guess... and split
this into ambiguous and invalid object ID errors, please?

-- 
Christian "naddy" Weisgerber                          naddy@mips.inka.de