"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: tog: basic diff regress
To:
Mark Jamsek <mark@jamsek.com>
Cc:
Game of Trees <gameoftrees@openbsd.org>
Date:
Sat, 15 Apr 2023 09:52:01 +0200

Download raw body.

Thread
On Sat, Apr 15, 2023 at 02:35:59PM +1000, Mark Jamsek wrote:
> The below diff applies on top, and makes $testname global so we can use
> that for each test script path. The objective is to minimise repeated
> copypasta errors. With this, if a new test is written that copypastas an
> existing similar one as a template, we don't have to worry about
> changing the script path each time. What do you think?

I think it would make more sense to export the GOT_TOG_TEST variable
to all tests, in order to match the name used by code in tog.c.

And could this variable be renamed to something that describes the
prupose more clearly, like TOG_TEST_SCRIPT?
(tog does not use a GOT_ prefix for its other environment variables)

Then the tests would read like this:

	cat <<EOF >$TOG_TEST_SCRIPT
  SCREENDUMP
  EOF