On 23-04-22 11:29AM, Mikhail wrote:
> On Sat, Apr 22, 2023 at 06:20:00PM +1000, Mark Jamsek wrote:
> > 
> > Thanks for testing these!
> > 
> > We need to request more commits to populate the timeline. This was
> > previously done during the resize event, but with this force fullscreen
> > toggle we're now only resizing the visible screen during the resize--not
> > the hidden parent or child view. The fix is to now do this when the
> > child view is closed in any configuration. Before we only requested more
> > commits if in a hsplit when the child view was closed:
> 
> Works for me, thank you!

Great! Thank you for testing all these. I'm working on some assessments
due this week so don't have the time and you've been a great help :)

I will write some test cases soon to cover all the potential breaks you
identified. And will also run tog locally with this patch. It touches
some critical view rendering code that as we saw can easily break so
some more use will be good. And now we have the test harness, I want
tests to be added with changes to make sure we have that coverage.

Thanks again, Mikhail, you saved me a lot of time testing these diffs!

-- 
Mark Jamsek <fnc.bsdbox.org|got.bsdbox.org>
GPG: F2FF 13DE 6A06 C471 CA80  E6E2 2930 DC66 86EE CF68