"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

Stefan Sperling <stsp@stsp.name>
Re: tog: call resize_log_view() when toggling fullscreen from child diff view
Mark Jamsek <mark@jamsek.com>
Game of Trees <gameoftrees@openbsd.org>
Sun, 23 Apr 2023 23:35:21 +0200

Download raw body.

On Sun, Apr 23, 2023 at 10:46:35PM +1000, Mark Jamsek wrote:
> When toggling fullscreen, we check if the view has a resize() function
> pointer to call. We do this for the log view to ensure enough commits
> are loaded to populate the view when going from a horizontal split to
> fullscreen, for example.
> However, we neglected to do this when toggling fullscreen from a child
> view if the parent view has the resize() routine; for example, when in
> a diff view opened from the log. The first of the two below diffs adds
> this check to call view->resize(). This fixes a bug that prevents
> scrolling the log from the diff view with the J keymap if on the last
> loaded commit. The second diff adds a test for this case.

It is very nice to see test cases being added for corner cases
like this! ok