Download raw body.
tog: call resize_log_view() when toggling fullscreen from child diff view
tog: call resize_log_view() when toggling fullscreen from child diff view
On Sun, Apr 23, 2023 at 10:46:35PM +1000, Mark Jamsek wrote: > When toggling fullscreen, we check if the view has a resize() function > pointer to call. We do this for the log view to ensure enough commits > are loaded to populate the view when going from a horizontal split to > fullscreen, for example. > > However, we neglected to do this when toggling fullscreen from a child > view if the parent view has the resize() routine; for example, when in > a diff view opened from the log. The first of the two below diffs adds > this check to call view->resize(). This fixes a bug that prevents > scrolling the log from the diff view with the J keymap if on the last > loaded commit. The second diff adds a test for this case. It is very nice to see test cases being added for corner cases like this! ok
tog: call resize_log_view() when toggling fullscreen from child diff view
tog: call resize_log_view() when toggling fullscreen from child diff view