"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Mark Jamsek <mark@jamsek.com>
Subject:
Re: add keyword support to tog
To:
Stefan Sperling <stsp@stsp.name>
Cc:
gameoftrees@openbsd.org
Date:
Wed, 19 Jul 2023 22:50:21 +1000

Download raw body.

Thread
Stefan Sperling <stsp@stsp.name> wrote:
> On Wed, Jul 19, 2023 at 09:19:48PM +1000, Mark Jamsek wrote:
> > As per the subject, this adds support for keywords to the tog blame,
> > diff, log, and tree commands, including regress.
> > 
> > The change to tog.c is quite minimal, although there's also a seemingly
> > unrelated change where we now return 1 when exiting with error rather
> > than 0, but this is so we can check for invalid keyword results
> > otherwise regress thinks tog succeeded unexpectedly. I'm unsure,
> > however, if we are exiting 0 here despite error for some reason?
> 
> No, I don't think there was a special reason for exit 0.
> Probably didn't matter up to now since there was no test suite ;)

:D

> ok for the diff

Thanks, committed!


-- 
Mark Jamsek <https://bsdbox.org>
GPG: F2FF 13DE 6A06 C471 CA80  E6E2 2930 DC66 86EE CF68