"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: optimise reading the file index
To:
Mark Jamsek <mark@jamsek.com>
Cc:
"Todd C. Miller" <millert@openbsd.org>, Christian Weisgerber <naddy@mips.inka.de>, gameoftrees@openbsd.org
Date:
Fri, 28 Jul 2023 20:15:59 +0200

Download raw body.

Thread
On Fri, Jul 28, 2023 at 03:14:43PM +1000, Mark Jamsek wrote:
> As op taught me on irc, 'got info <path>' is good for this case, and
> while we're seeing some improvement there, it doesn't seem to be showing
> any improvement in the time it takes to draw the base commit marker in
> tog. However, it is also making the new 'got branch -l' about 30% faster
> and that takes the base commit of each file in the index into account
> the same way tog's new base commit marker does, so there could be some
> other reason in tog for the delay.

Right. Then let's use branch -l as the benchmark and forget about tog for now.
It's not even very important to fix the commit-marker delay in tog, just
something I noticed. And it seems Omar has now figured out why the routine
which is reading the file index is so slow (tons of realloc, making the
hundreds of fread calls a secondary issue).

Overall, I am very happy with the progress that's being made on this :)