"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: gotwebd: getting rid of the interface handling
To:
Omar Polo <op@omarpolo.com>
Cc:
gameoftrees@openbsd.org
Date:
Wed, 15 Nov 2023 09:28:22 +0100

Download raw body.

Thread
On Wed, Nov 15, 2023 at 01:22:40AM +0100, Omar Polo wrote:
> As discussed a few times with Stefan, this removes the ability to do
> `listen on $interface_name`.  We don't monitor address configuration
> changes and we don't believe gotwebd should.
> 
> -----------------------------------------------
> commit 0d7393835404e823d295758dd9183ad6b9d91ff0 (main)
> from: Omar Polo <op@omarpolo.com>
> date: Tue Nov 14 23:48:41 2023 UTC
>  
>  gotwebd: disable listening on interfaces
>  
> diff b1c090542f4ecaf993fc81468338839febcb8e37 0d7393835404e823d295758dd9183ad6b9d91ff0
> commit - b1c090542f4ecaf993fc81468338839febcb8e37
> commit + 0d7393835404e823d295758dd9183ad6b9d91ff0
> blob - 4e45a0dbe7ee90444aa4cf887748864c25126a9a
> blob + be5c3a92ffd9e06c34e2912545d1880cb973893e
> --- gotwebd/gotwebd.conf.5
> +++ gotwebd/gotwebd.conf.5
> @@ -102,14 +102,6 @@ argument may be number or a service name defined in
>  May be specified multiple times to build up a list of listening sockets.
>  However, a given combination of address and port may only be used by
>  one server.
> -.Pp
> -If a network interface name is given as
> -.Ar address
> -argument then
> -.Xr gotwebd 8
> -will obtain the list of addresses on this interface only on startup.
> -Any future changes to the address configuration of the interface will
> -be ignored.
>  .It Ic listen on socket off
>  Disable use of unix socket.
>  .It Ic listen on socket Ar path

OK stsp@ but note that on line 94 gotwebd.conf.5 still claims
interface names were supported, which needs adjustment as well:

"""
Valid
.Ar address
arguments are hostnames, IP4 addresses, IPv6 addresses, and network
interface names.
"""