"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: Gotwebd dark mode accessible colors
To:
Kyle Ackerman <kackerman0102@gmail.com>
Cc:
gameoftrees@openbsd.org
Date:
Wed, 6 Dec 2023 21:58:24 +0100

Download raw body.

Thread
On Wed, Dec 06, 2023 at 02:44:33PM -0600, Kyle Ackerman wrote:
> Here is a patch for dark mode on gotwebd to make diffs more
> accessible to people facing color blindness, pointed out by Stefen.

I have applied this on got.gameoftrees.org and it looks great, thanks!

> diff /home/kyle/src/got-dev
> commit - 9e83097f9b3fc262356cc5189409a0e472d1084b
> path + /home/kyle/src/got-dev
> blob - c6f473ced0d7b7454f210dfaa119b63cd96d2ba4
> file + gotwebd/files/htdocs/gotwebd/gotweb.css
> --- gotwebd/files/htdocs/gotwebd/gotweb.css
> +++ gotwebd/files/htdocs/gotwebd/gotweb.css
> @@ -465,10 +465,10 @@ dd {
>  	}
>  
>  	.diff_minus, .diff_submodule {
> -		color: #FF5555;
> +		color: #FF79C6;
>  	}
>  	.diff_plus, .diff_symlink, .diff_author {
> -		color: #50FA7B;
> +		color: #8BE9FD;
>  	}
>  	.diff_chunk_header, .diff_date {
>  		background-color: unset;
> 
> 
> I will point out that this does not use the same colors as the original
> diff colors.  The darkcyan does not contrast well with the dark mode
> background.  Just to have a brighter cyan, I used the one from the
> Dracula spec.  Additionally, to keep everything on theme, I used the magenta from
> there also.  Not sure how accessible these colors are, and I also don't
> want to assume. 
> 
> Looking for as much feedback/comments/suggestions as I can get.
> 
>