"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Omar Polo <op@omarpolo.com>
Subject:
Re: allow remotes without urls in git config; add tests
To:
Stefan Sperling <stsp@stsp.name>
Cc:
Kyle Ackerman <kackerman0102@gmail.com>, James Cook <falsifian@falsifian.org>, gameoftrees@openbsd.org
Date:
Thu, 25 Jan 2024 12:45:15 +0100

Download raw body.

Thread
On 2024/01/25 11:32:03 +0100, Stefan Sperling <stsp@stsp.name> wrote:
> On Wed, Jan 24, 2024 at 11:58:46PM -0600, Kyle Ackerman wrote:
> > With your modification to got-read-gitconfig.c and his new regressions,
> > your diff throws 2 failed regressions because of "privsep peer process
> > closed pipe". 
> 
> Thanks Kyle!
> 
> I see the mistake I made, which Omar also pointed out off-list.
> 
> This is a fixed version which passes all tests including the ones
> added by James. Again, this is just a style change relative to the
> original diff by James.

reads fine to me; ok op@