Download raw body.
gotwebd: guard against missing qs->file
On 2024/01/29 14:20:43 +0100, Stefan Sperling <stsp@stsp.name> wrote: > On Mon, Jan 29, 2024 at 01:52:30PM +0100, Omar Polo wrote: > > @@ -218,6 +223,10 @@ gotweb_process_request(struct request *c) > > > > switch (qs->action) { > > case BLAME: > > + if (qs->folder == NULL || qs->file == NULL) { > > This change introduces a small inconsistency: > qs->folder is allowed to be NULL in got_output_file_blame() which now > becomes impossible to reach. I realized it, but now we seem to always emit a folder parameter[1], maybe empty, so I was considering being more strict here. I think got_oput_file_blame() did it either to be pedantic against bad input or because before folder was not always set. [1]: there is one case in the tree code that emits a BLOB url and I'm not sure if `folder' has to be set at that point. I can remove the qs->folder check if you prefer. > > + error = got_error(GOT_ERR_BAD_QUERYSTRING); > > + goto err; > > + }
gotwebd: guard against missing qs->file