"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

Stefan Sperling <stsp@stsp.name>
Re: tog: add option for topological sorting in log view
Christian Weisgerber <naddy@mips.inka.de>
Mon, 1 Apr 2024 09:10:29 +0200

Download raw body.

On Fri, Mar 29, 2024 at 05:43:43PM +0100, Christian Weisgerber wrote:
>  tog: add key binding 't' to toggle topological sorting in log view
> I assume we want a key binding for this?  't'?
> I'm not sure where to sort it in the man page / help screen.

I am ok with both diffs, but there is a caveat:

On a non-trivial repository, such as git.git, the tog UI freezes
for several seconds when I press 'b' and then 't'. I don't mind
this problem in the initial version but it would be good to follow
up with UI improvements soon.

There are plans to improve toposort performance by using Git's commit-graph
file, which would likely make this a non-issue. But getting there will
require a substantial amount of work.

Meanwhile, we'll want to avoid the impression that tog is stuck.
The easiest way would be doing what the diff view does, when it shows
"Diffing..." at the top of the window while a diff is being generated.
Even better, we could add a progress callback to the commit graph such
that tag can display a progress percentage or counter while sorting commits.