On 2024/04/09 15:51:10 +0200, Stefan Sperling <stsp@stsp.name> wrote:
> On Tue, Apr 09, 2024 at 03:32:01PM +0200, Omar Polo wrote:
> > wrote this diff while debugging the date formatting issue just fixed,
> > when i realized that we could save a few lines by using strftime().
> > since I already wrote this diff for repo_write.c, here's also the rest
> > of the get_datestr() copies converted.  (well, except got-notify-email)
> > 
> > the output is exactly the same as before.
> 
> asctime_r() is locale independent, but strftime() may have locale-specific
> behaviour.
> 
> This change might affect the output of -portable running in non-English
> locales, resulting in partially translated display.
> Given that we don't support i18n I think it makes more sense to keep
> everything in English.

and will also break the regress.

ouch, i missed the difference in the locale handling.  I'm dropping the
diff then.