"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Omar Polo <op@omarpolo.com>
Subject:
Re: Diff memory leak
To:
Mark Jamsek <mark@jamsek.com>
Cc:
Stefan Sperling <stsp@stsp.name>, Kyle Ackerman <kackerman0102@gmail.com>, gameoftrees@openbsd.org
Date:
Fri, 31 May 2024 13:29:50 +0200

Download raw body.

Thread
On 2024/05/31 20:14:58 +1000, Mark Jamsek <mark@jamsek.com> wrote:
> Kyle's right in that we leak this lines array because it gets allocated
> in diffreg.c:got_diffreg_output() but stsp's right in that the problem
> is elsewhere with some incorrect NULL pointer checks.
> 
> The below diff plugs the leak for me; can you please confirm it does for
> you, too, Kyle?

i should have realized that i needed to diff trees since Kyle was
plugging the leak in diff_objects_as_trees()... sorry :/

the diffs seems ok to me and fixes the leak.  thanks!