On 2024/07/03 00:19:51 +1000, Mark Jamsek <mark@jamsek.com> wrote:
> Because we call span_wline() to compute how many wchar_t characters
> (i.e., columns) to skip when rendering the diff view before trimming the
> trailing L'\n', we replace the L'\n' character with L'\.' as wcwidth(3)
> returns -1 for non-printables.
> 
> To fix this, move the span_wline() call that finds the offset to after
> the newline has been trimmed.
> 
> The added regress test is a good way to visualise the problem if you run
> the test before building the new tog binary.
> 
> I stumbled over this by chance when scrolling a diff view with a very
> short log message. But it also shows in short diff lines too, which the
> test case evinces.
> 
> In my tree, this commit is on top of the diff in my previous mail but
> it might apply cleanly without it.
> 
> ok?

ok op@, thanks!


Omar Polo