"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Mark Jamsek <mark@jamsek.com>
Subject:
Re: got-build-regress.sh regress failure
To:
Omar Polo <op@omarpolo.com>
Cc:
op@omarpolo.com, gameoftrees@openbsd.org
Date:
Tue, 20 Aug 2024 17:02:43 +1000

Download raw body.

Thread
Omar Polo <op@omarpolo.com> wrote:
> On 2024/08/19 21:13:32 +0200, op@omarpolo.com wrote:
> > ===> regress/tog
> > ==== log ====
> > ./log.sh -q -r "/home/chiaki/tmp/"
> > --- /home/chiaki/tmp/tog-test-log_mark_keymap-BLkkt3cI4L/view.expected	Mon Aug 19 21:13:31 2024
> > +++ /home/chiaki/tmp/tog-test-log_mark_keymap-BLkkt3cI4L/view	Mon Aug 19 21:13:32 2024
> > @@ -1,5 +1,5 @@
> >  commit 7090dc7c6201101f9af2ddea91904ab6a6f45015 [2/2]
> > -2024-08-19 f0d07c2f flan_hacker ~[master] new alpha
> > +2024-08-19 f0d07c2f flan_hacker  [master] new alpha
> >  2024-08-19 7090dc7c flan_hacker  adding the test tree
> 
> I've seen this a few times.  it happens randomly, haven't managed to
> look yet at why it fails :/

I suspect this is due to capturing the screendump before the base commit
marker has been drawn. If so, this should fix it. Please let me know if
the test reliably passes on your test machine with this applied.


commit bcba83d16a88f29bed450e90b237bb04b5559f68 (main)
from: Mark Jamsek <mark@jamsek.dev>
date: Tue Aug 20 07:00:37 2024 UTC

insert wait instruction in tog log mark keymap test

On slower machines, the test may fail due to capturing
the screendump before the base commit marker is drawn.

M  regress/tog/log.sh  |  2+  0-

1 file changed, 2 insertions(+), 0 deletions(-)

commit - 8cc4eb801418181a7eddf2ad28d85b4e60661ae7
commit + bcba83d16a88f29bed450e90b237bb04b5559f68
blob - 0b8323f8cea5abb4777743d902c28ee9388c52f4
blob + dc5a64d8bdc14067f6bc59ebcbdbeedaf610d748
--- regress/tog/log.sh
+++ regress/tog/log.sh
@@ -767,6 +767,7 @@ test_log_mark_keymap()
 	cat <<-EOF >$TOG_TEST_SCRIPT
 	j
 	m		mark commit
+	WAIT_FOR_UI
 	SCREENDUMP
 	EOF
 
@@ -801,6 +802,7 @@ test_log_mark_keymap()
 	j
 	m		mark commit
 	m		unmark commit
+	WAIT_FOR_UI
 	SCREENDUMP
 	EOF
 


-- 
Mark Jamsek <https://bsdbox.org>
GPG: F2FF 13DE 6A06 C471 CA80  E6E2 2930 DC66 86EE CF68