On Mon, Nov 04, 2024 at 09:56:04PM +1100, Mark Jamsek wrote:
> Stefan Sperling <stsp@stsp.name> wrote:
> > Should errors returned from install_blob() not be checked here?
> 
> We break on the next line and go straight to done: already because
> path_content is NULL when revert_binary_file is set, which is why I
> left it out, but it's much clearer to have an explicit check there.
> The below diff adds that, which is the only change to lib/worktree.c
> plus expands the stage -p binary test.

An explicit error check reads better indeed, thanks.

> I still need to add unstage and revert coverage, though, but I'm not
> sure I'll do that tonight as my eyes are falling out of their sockets
> already :)

Then please put it in with my OK and add more tests later. Good night :)