"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Christian Weisgerber <naddy@mips.inka.de>
Subject:
Fix pointer indirection level
To:
gameoftrees@openbsd.org
Date:
Fri, 29 Nov 2024 21:03:09 +0100

Download raw body.

Thread
On FreeBSD I get this warning:

--- ../lib/fetch.o ---
../lib/fetch.c:186:9: warning: attempt to call free on non-heap object
'refname' [-Wfree-nonheap-object]
  186 |                         free(&refname);
      |                              ^

ok?

-----------------------------------------------
commit 86ca4397736d762311f6118e5c91ac5844edb6ce (main)
from: Christian Weisgerber <naddy@mips.inka.de>
date: Fri Nov 29 20:01:05 2024 UTC
 
 fix pointer indirection level
 
diff d2752c62796d1ed1a7d9c3a39558e7d66a57f8e4 86ca4397736d762311f6118e5c91ac5844edb6ce
commit - d2752c62796d1ed1a7d9c3a39558e7d66a57f8e4
commit + 86ca4397736d762311f6118e5c91ac5844edb6ce
blob - d6fcc31ded7e98bfd09f6f92081aa5e857628837
blob + 7c67b8bd27d8f0b14c6c6ab064426ba9ca064259
--- lib/fetch.c
+++ lib/fetch.c
@@ -171,7 +171,7 @@ got_fetch_pack(struct got_object_id **pack_hash, struc
 
 	TAILQ_FOREACH(re, &my_refs, entry) {
 		struct got_object_id *id;
-		const char *refname;
+		char *refname;
 
 		if (got_ref_is_symbolic(re->ref))
 			continue;
@@ -188,7 +188,7 @@ got_fetch_pack(struct got_object_id **pack_hash, struc
 		if (err)
 			goto done;
 		if (new == NULL){
-			free(&refname);
+			free(refname);
 			free(id);
 		}
 

-- 
Christian "naddy" Weisgerber                          naddy@mips.inka.de