"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Maxim <glokaya@kuzdra.org>
Subject:
got_opentemp_named_fd(): add missing mkstemps() template to error message
To:
gameoftrees@openbsd.org
Date:
Tue, 17 Dec 2024 15:09:11 +0100

Download raw body.

Thread
When "got commit" failed, its error message "mkstemp: Permission denied"
wasn't very useful. I brought this problem up on libera.chat and stsp
suggested to print the path template.

M  lib/opentemp.c  |  1+  1-

1 file changed, 1 insertion(+), 1 deletion(-)

commit - d8bca70b3c1687b6af0b843a6e2df209dbdfcc04
commit + 3eb9594c9d966adcb7b99de4e12536ade869b9f2
blob - a0d0c2213dfee3f56549ae2f92dc2415d3d9744d
blob + 86b9e6ad0e447517a87f4cc75067ed9bb2f76e25
--- lib/opentemp.c
+++ lib/opentemp.c
@@ -111,7 +111,7 @@ got_opentemp_named_fd(char **path, int *outfd, const c
 
 	fd = mkstemps(*path, strlen(suffix));
 	if (fd == -1) {
-		err = got_error_from_errno("mkstemp");
+		err = got_error_from_errno2("mkstemps", *path);
 		free(*path);
 		*path = NULL;
 		return err;