"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: plug some leaks in `got import`
To:
Mark Jamsek <mark@jamsek.com>
Cc:
gameoftrees@openbsd.org
Date:
Thu, 19 Dec 2024 02:29:01 +0100

Download raw body.

Thread
On Thu, Dec 12, 2024 at 03:50:02PM +1100, Mark Jamsek wrote:
> Stefan Sperling <stsp@stsp.name> wrote:
> > On Wed, Dec 11, 2024 at 10:59:51PM +1100, Mark Jamsek wrote:
> > > Spotted by chance when investigating moving get_author() to the library:
> > > we leak some objects with early returns in a couple error cases instead
> > > of going to done to cleanup; and we also forgot to free the path_dir
> > > char pointer, and ignores pathlist.
> > 
> > ok stsp@
> 
> Thanks, stsp. But I forgot all about cvg :/
> 
> Below diff is of the same fixes applied to cvg.c:cmd_import()

thanks, ok!