On Sat, Dec 28, 2024 at 12:45:16AM +1100, Mark Jamsek wrote:
> Mark Jamsek <mark@jamsek.com> wrote:
> > Mark Jamsek <mark@jamsek.com> wrote:
> > > Mark Jamsek <mark@jamsek.com> wrote:
> > > 
> > > As such, below are two diffs: the first plugs the object id leak that
> > > happens when the object id does not reference a commit, and when the
> > > call to got_object_open_as_tag() fails. The second is the previous diff
> > > slightly modified, which adds the ability to select from the ref view
> > > nested tags that resolve to commits, and makes selection of tags that
> > > point to non-commit objects non-fatal.
> > > 
> > > Regress still to come :)
> > 
> > Here are two regress diffs: the first adds some long overdue basic ref
> > view tests; and the second adds two tests covering the previous diff
> > that adds support for nested tags resolving to commit objects, and fixes
> > the fatal error when selecting tags that point to non-commit objects.
> 
> Updated the first diff to add the new ref view regress target to the
> makefile. Second diff is unchanged but added below for convenience.

I've read through the entire thread and didn't spot any issues beyond
the obj_id leak you've already found.  ok