"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Mark Jamsek <mark@jamsek.com>
Subject:
Re: add ssh -i support
To:
Stefan Sperling <stsp@stsp.name>
Cc:
gameoftrees@openbsd.org
Date:
Sat, 11 Jan 2025 19:20:59 +1100

Download raw body.

Thread
Stefan Sperling <stsp@stsp.name> wrote:
> On Fri, Jan 10, 2025 at 12:00:57PM +0100, Stefan Sperling wrote:
> > Add a -i option to got clone, fetch, send, as well as cvg clone,
> > update, commit. This allows ad-hoc use of SSH private keys without
> > having to create entries in ~/.ssh/config.
> > 
> > The test suite for an upcoming gotsysd(8) daemon needs this to log
> > into temporary test VMs with temporary SSH keys, both generated by
> > the test suite.
> > 
> > ok?
> 
> Updated diff, with two issues in the previous diff repaired:
> 
> 1) The -i option wasn't added to getopt in cmd_send().
> 
> 2) usage() output was not updated. This was already a problem when
>    the -J options were added; I've added -J to usage() on the main
>    branch, and this diff has been rebased accordingly.

good catch!

> 
> M  cvg/cvg.1                   |  21+   0-
> M  cvg/cvg.c                   |  27+  13-
> M  got/got.1                   |  21+   0-
> M  got/got.c                   |  25+  15-
> M  include/got_fetch.h         |   2+   1-
> M  include/got_send.h          |   2+   1-
> M  include/got_worktree_cvg.h  |   2+   2-
> M  lib/dial.c                  |   6+   2-
> M  lib/fetch.c                 |   3+   2-
> M  lib/got_lib_dial.h          |   2+   1-
> M  lib/send.c                  |   2+   2-
> M  lib/worktree_cvg.c          |  10+   8-
> 
> 12 files changed, 123 insertions(+), 47 deletions(-)

ok


-- 
Mark Jamsek <https://bsdbox.org>
GPG: F2FF 13DE 6A06 C471 CA80  E6E2 2930 DC66 86EE CF68