Stefan Sperling <stsp@stsp.name> wrote:
> This adds a test case for email notification where a tag and modified
> file are sent to the server in the same operation.
> 
> There was a problem with notifications when I sent the 0.109 tag in
> combination with a modified CHANGES file earlier today, where the gotd
> notify process died. However, this test does not (yet?) reproduce this
> particular issue.
> 
> Each notifciation causes a separate invocation of got-notify-email
> and thus 2 connections are made in this test case.
> I needed to add another custom Perl server for this because the nc-based
> hacks cannot deal with multiple SMTP connections. This is too limited for
> testing non-basic scenarios so I would like to propose my smtp-server
> script for inclusion in the test suite.
> 
> 
> Does this smtp-server script look fine?
> It adds a dependency on yet another perl cpan module but this can
> easily be installed from packages.
> 
> If this approach looks fine then I would like to replace the use
> of nc -l hacks in the other tests with this new script as well.
> 
> ok?

admittedly not tested since i'm in a bit of a rush, but it reads fine to
me, and the added perl dependency it's just for tests so it's not a big
deal.  it also seems a fairly simple package.

(maybe we could also have hacked something without the extra dep, but
again, this is simple enough and just for tests, so fine with me)

assuming it works for you, ok op@ ;)