"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: Reuse of packed/loose objects?
To:
Christian Weisgerber <naddy@mips.inka.de>, gameoftrees@openbsd.org
Date:
Tue, 18 Mar 2025 13:11:21 +0100

Download raw body.

Thread
On Mon, Mar 17, 2025 at 03:48:43PM +0100, Stefan Sperling wrote:
> We can be reasonably confident that
> a successfully indexed pack file contains the expected file contents. We
> shouldn't only be relying on the pack index, though. We need to actually open
> the packed object and close it again to ensure that the object is readable.

Checking the code, I noticed that this assumption of mine was wrong:

> Opening and closing implicitly verifies the stored content's checksum, too.

We are not yet validating checksums of objects objects extracted from pack
files. This has only been implemented for loose objects so far.
Looks like I left packed objects for later at the time but never returned to
finish this work. If anyone wants to pick it up, feel free to do so, but please
let me know so we can avoid duplicated effort.