"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Kyle Ackerman <kack@kyleackerman.net>
Subject:
umask assumptions in regressions
To:
"gameoftrees@openbsd.org" <gameoftrees@openbsd.org>
Date:
Fri, 28 Mar 2025 21:14:52 +0000

Download raw body.

Thread
  • Kyle Ackerman:

    umask assumptions in regressions

Recently I have been building -portable on different platforms and noticed some regressions failures 
(specifically in regress/cmdline/diff.sh). The regression has assumption that the umask is 022 (file perm: 644).
On other platforms, the mask can differ. Setting the umask in common.sh is a simple solution. This i mainly meant for -portable
but doesn't affect any regressions in -main.


diff /home/kyle/src/got
path + /home/kyle/src/got
commit - a80b99e21fc857df67ec90b2b3d86ea3b87de4b1
blob - b17caad2195bf8f03071162075d2c331a52f4894
file + regress/cmdline/common.sh
--- regress/cmdline/common.sh
+++ regress/cmdline/common.sh
@@ -14,6 +14,7 @@
 # ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
 # OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 
+umask 022
 regress_run_only=""
 
 export GIT_AUTHOR_NAME="Flan Hacker"


Thoughts/Comments/Suggestions?