"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Omar Polo <op@omarpolo.com>
Subject:
Re: stop using got_repo_map_path() in gotwebd
To:
gameoftrees@openbsd.org
Date:
Fri, 11 Apr 2025 15:56:47 +0200

Download raw body.

Thread
On 11/04/25 15:38, Stefan Sperling wrote:
> got_repo_map_path() is supposed to figure out whether an input path
> corresponds to an on-disk file in a non-bare git repository, and map
> such paths to in-repository paths. In other cases it will just return
> the input path as-is.
>
> Since gotwebd only deals with repository-relative input paths in the
> first place, it can just use input paths from query strings as-is.
>
> Avoids realpath errors seen in my gotwebd server logs, such as:
>   gotweb_render_blame: got_output_file_blame: realpath: template/tmpl.c: \
>     Permission denied
> With the blame page showing a header but no file content.
>
> ok?

love this; ok op@

> M  gotwebd/got_operations.c  |  11+  44-
>
> 1 file changed, 11 insertions(+), 44 deletions(-)
>
> commit - eaef053d0e02ef1c9fc0f3b86e402e87ba085efa
> commit + 4dac45af0751f575663d09d961ea68e0026064cd
> blob - f60b86ed8bb810bc93dbee821cc7991a64152284
> blob + 0910b7745841a7f283764674dfa9ff44f77044a2