"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: optimize got-fetch-http a bit
To:
Omar Polo <op@omarpolo.com>
Cc:
gameoftrees@openbsd.org
Date:
Thu, 17 Apr 2025 14:28:46 +0200

Download raw body.

Thread
On Thu, Apr 17, 2025 at 01:59:30PM +0200, Omar Polo wrote:
> Stefan Sperling <stsp@stsp.name> wrote:
> > On Tue, Apr 15, 2025 at 08:11:42AM +0200, op@omarpolo.com wrote:
> > > +
> > > +		if (out != NULL) {
> > > +			fwrite(rbuf->buf + rbuf->cur, 1, avail, out);
> > 
> > Please check for errors from fwrite() instead of ignoring them.
> > I realize this is always going to stdout, but I would prefer to keep
> > error checking idioms in place everywhere.
> 
> Fair enough; there were none before and that's why I haven't added them,
> but I agree.  Here's an updated diff.

thanks, ok by me!