"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
"Omar Polo" <op@omarpolo.com>
Subject:
Re: got-read-pack commit coloring fix
To:
Stefan Sperling <stsp@stsp.name>
Cc:
gameoftrees@openbsd.org
Date:
Fri, 15 Aug 2025 13:28:50 +0200

Download raw body.

Thread
Stefan Sperling <stsp@stsp.name> wrote:
> On Thu, Aug 14, 2025 at 06:43:45PM +0200, Omar Polo wrote:
> > I really like the improvements.  ok op@!
> 
> These have been committed (commit notifications were missing due to an unrelated
> bug in gotd.)
> 
> There was a problem in the final commit of this series which I have now reverted.
> Here is a replacement fix which seems to work well and does not break cleanup tests:
> 
> 
> better fix for long loop bug during commit coloring with offloading
> 
> Repaint already queued commits in the main process instead of removing them
> from the queue. Otherwise we may never converge to a state where all commits
> are marked as skipped. Instead such commits can inherit color keep and we'll
> keep on asking got-read-pack to paint more commits for a very long time.

took a bit to understand, but looks good to me.  ok op@

> M  lib/pack_create_privsep.c  |  11+  10-
> 
> 1 file changed, 11 insertions(+), 10 deletions(-)
> 
> commit - 5abe061a03aa6b587c595d904418740002d94956
> commit + 35a48c78421f5dc5a05d329adc5e64454eac5b3c
> blob - 9afa74d1d08cfdfe6e45e1bd1911a37c1585184b
> blob + c29bd335ba24926a633d0fdfb8bbfb2624c42d73