"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
"Omar Polo" <op@omarpolo.com>
Subject:
Re: gotwebd: parse fcgi records under pledge("stdio")
To:
Stefan Sperling <stsp@stsp.name>
Cc:
gameoftrees@openbsd.org
Date:
Sat, 06 Sep 2025 13:03:12 +0200

Download raw body.

Thread
Stefan Sperling <stsp@stsp.name> wrote:
> This adds another gotwebd process which runs with pledge("stdio")
> and moves the fcgi params parsing into this process.
> 
> My long-term plan is to also parse the querystring in this process
> such that gotweb.c and other processes which we need for supporting
> authentication will not have to do any parsing themselves but just
> deal with data in structs and fixed-sized buffers.
> 
> This diff is not well tested and probably has issues. I mainly want
> to see if people think this is going in the right direction. Is it?
> 
> This will only compile on -current.
> The new imsg_set_maxsize() API in -current makes it easy to pass
> larger structures around so we won't need to do manual chunking
> even if our request and querystring structs are somewhat large.
> 
> (One known issue is that requests aren't terminated properly and need
> to time out to be removed in sockets.c, because gotweb.c does not yet
> notify sockets.c when a request is finished.)

good (and long) enough to hit main and be improved in tree IMHO.  ok op@

took a bit of time to digest this one, with all the moving around, but i
like the direction =)