Stefan Sperling <stsp@stsp.name> wrote:
> 'got send' can fail pack file indexing checks performed by stock
> git servers or github servers, which check for connected history
> on all branches sent by the client. This problem will be more
> easily triggered when merge commits are used by the project.
> 
> The cause of this problem is trivial: We simply forget to add
> parent commits to the pack file. The patch below fixes this.
> 
> ok?

okay op@

> By the way, gotd should be doing this connectivity check as well,
> At present, gotd accepts pack files with missing objects. I've seen
> this happen a few times when syncing changes from nsh.git which is
> a project that uses merge commits on github.

yeah... agreed.

> M  lib/pack_create.c  |  84+  27-
> 
> 1 file changed, 84 insertions(+), 27 deletions(-)
> 
> commit - 91c7e219d492ac01fd8fb77133a4d5a3d7f712f2
> commit + 0cbd78c39bf39cebe6878c54fd1ac84a2e0bffd7
> blob - 1b2041e539f692fb2086e5f51bbb9b4b269ebd22
> blob + b15ae6f60499bc24f6721167a14c71872476f7d0