"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Thomas Adam <thomas@xteddy.org>
Subject:
Re: fix duplicated tree item with prefix checkout
To:
Omar Polo <op@omarpolo.com>, gameoftrees@openbsd.org
Date:
Sat, 18 Jul 2026 18:31:55 +0100

Download raw body.

Thread
On Sat, 18 Jul 2026 at 18:27, Stefan Sperling <stsp@stsp.name> wrote:
>
> On Sat, Jul 18, 2026 at 07:25:29PM +0200, Omar Polo wrote:
> > "Omar Polo" <op@omarpolo.com> wrote:
> > > +   got_path_strip_trailing_slashes(absprefix);
> >
> > stuff like this was broken other tests, i was focussing on mine and
> > haven't noticed, apologise.  the correct pattern seems to be
> >
> >       if (!got_path_is_root_dir(...))
> >               got_path_strip_trailing_slashes(...);
> >
> > which probably doesn't work for pathological cases like "//", but it's a
> > net improvement over what we have, and i'll take a look at making
> > got_path_strip_trailing_slashes handier to use.
> >
> > updated diff:
>
> Nice.  ok stsp@

LGTM.  OK thomas@

[...]

-- Thomas Adam