"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Mikhail Pchelin <misha@freebsd.org>
Subject:
Re: [PATCH] add vim-style search wrapped message
To:
gameoftrees@openbsd.org
Date:
Fri, 24 Jul 2026 20:43:57 +0300

Download raw body.

Thread
On Fri, Jul 24, 2026 at 07:29:01PM +0200, Stefan Sperling wrote:
> On Fri, Jul 24, 2026 at 10:05:19AM +0300, Mikhail Pchelin wrote:
> > [please keep me cc'ed]
> >
> > This patch adds messages about search wrap, helps if you scroll large
> > diff and got past the last search entry.
> >
> > Worth a review?
>
> Thanks, I like this!
>
> Could this feature be extended to other views (log, blame, diff) for
> consistency?
>
> Or is there a reason why this can only be done in the tree and ref views?

It's already there for blame and diff views, they use
'search_next_view_match' as their 'view->search_next', tree and ref use
their own, that's why they were updated.

'tog log' is special, it says 'no more matches' and stops it doesn't
wrap, I think this behaviour is worth keeping as is.