"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: got diff vs file names with whitespaces
To:
Omar Polo <op@omarpolo.com>
Cc:
gameoftrees@openbsd.org
Date:
Fri, 6 Nov 2026 16:19:31 +0100

Download raw body.

Thread
On Fri, Nov 06, 2026 at 03:51:29PM +0100, Omar Polo wrote:
> Stefan Sperling <stsp@stsp.name> wrote:
> > Is Larry patch trying to detect cases like "--- path (working copy)" (no \t)
> > and then tries to cleverly strip everything to leave just the "path" part?
> > Such that paths are truncated if they contain spaces without a trailing tab?
> 
> bingo
> 
> our patch doesn't care, and just splits on tab, which i think it's fine.
> 
> git diff does what i was doing in my first diff, i.e. add the trailing
> tab only when the file name contains a space.

Fine, let's always print the trailing tab then.

> i don't mind adding it always, especially after the pain of fixing all
> the regress :P

You forgot one case in tog regress:
test failed; leaving test data in /tmp/tog-test-diff_p_keymap-nKfiwX2TRB

And some of gotwebd regress is also failing.