From: Stefan Sperling <stsp@stsp.name>
Subject: Re: tog log & got-read-pack on the fly:
To: Martin Pieuchot <mpi@openbsd.org>
Cc: gameoftrees@openbsd.org
Date: Tue, 15 Oct 2019 12:30:52 +0200

On Tue, Oct 15, 2019 at 11:53:12AM +0200, Martin Pieuchot wrote:
> On 15/10/19(Tue) 11:11, Stefan Sperling wrote:
> > I forgot to ask earlier: Can the backspace key still abort the search
> > in this case?
> 
> It doesn't.

It does for me. I run the same steps as you outlined below and then
I can press backspace to abort the search. It will stop loading
commits and give control of the cursor back to me.

Is there a problem with the backspace key in your case?
What if you bind this action to another key?
For instance, this diff binds it to the 'a' key:

diff 7d5fb7e82303b4affede22230a8763512045838f /home/stsp/src/got
blob - 082650a7623054ef35d2d467e3d678240ee3ddf3
file + tog/tog.c
--- tog/tog.c
+++ tog/tog.c
@@ -1834,7 +1834,7 @@ search_next_log_view(struct tog_view *view)
 		if (errcode)
 			return got_error_set_errno(errcode,
 			    "pthread_mutex_lock");
-		if (ch == KEY_BACKSPACE) {
+		if (ch == 'a') {
 			view->search_next_done = 1;
 			return NULL;
 		}

> > I am still unable to reproduce this. Is anyone else seeing this?
> 
> I've the openbsd git tree in /home/os/openbsd and I do
> 
> cd /home/os/openbsd/sys && tog log -c master .
> 
> Then I search for a weird pattern that doesn't match anything,  at that
> moment the top bar says:
> 
> commit ........................................ /sys [1/XXX] searching...
> 
> And count until reaching the end commit:
> 
> commit d4ce8ef6e9b9ee3e216ced681f963a2ce288d25a /sys [1/78483] master, origin/ma
> 
> Then I can finally move around.
>