From: Stefan Sperling Subject: Re: got remove recursion To: Tracey Emery Cc: gameoftrees@openbsd.org Date: Fri, 13 Dec 2019 00:33:38 +0100 On Thu, Dec 12, 2019 at 01:51:58PM -0700, Tracey Emery wrote: > On Thu, Dec 12, 2019 at 01:37:11PM -0700, Tracey Emery wrote: > > > > Thanks for combing through the details. It makes much more sense now. > > Below is a diff based on the add recursion diff. I think it's greatly > > improved. Thoughts? > > > > Let's simplify things a little further. This is much better indeed. Thanks! Let's roll with this. You will need to rebase on top of my diff which I just committed to add the missing '0' argument here: /home/stsp/src/got/got/../lib/worktree.c:2868:51: error: too few arguments to function call, expected 10, have 9 schedule_addition, &saa, NULL, NULL, no_ignores);