From: Edgar Pettijohn <edgar@pettijohn-web.com>
Subject: Re: Makefile patch
To: gameoftrees@openbsd.org
Date: Sat, 4 Jan 2020 11:44:27 -0600


On 2020-01-04 11:25, Klemens Nanni wrote:
> On Sat, Jan 04, 2020 at 11:12:01AM -0600, Edgar Pettijohn wrote:
>> Came across got from a misc@ posting. Tried to build on netbsd and hit a
>> makefile incompatibility.
> Regardless of this, may I suggest `.if ${GOT_RELEASE:L} == "yes"' as
> done in other makefiles such as bsd.port.mk(5);  that makes it work no
> matter the case.
>   
>> -.if ${GOT_RELEASE} == "Yes"
>> +.if "${GOT_RELEASE}" == "Yes"
> What exactly is the incompatibility?  Does NetBSD's make not support
> unquoted variables?

Thats my guess.

>   What error do you get?
>
make[1]: "/home/edgar/got/libexec/../Makefile.inc" line 7: Malformed 
conditional (${GOT_RELEASE} == "Yes")
make[1]: Fatal errors encountered -- cannot continue
make[1]: stopped in /home/edgar/got/libexec

*** Error code 1

Thanks,


Edgar