From: Christian Weisgerber <naddy@mips.inka.de>
Subject: Re: tog log: correct number of lines to page up/down
To: gameoftrees@openbsd.org
Date: Thu, 26 Mar 2020 17:17:51 +0100

Stefan Sperling:

> How does this look?
-snip-

This works great.  The log view now always fetches at least as many
entries as required to fulfill a scroll request.


It exposes some minor oddities:

* At startup, one entry too much is fetched.
  Should commits_needed be initialized to view->nlines - 1 in
  open_log_view()?

* Paging down always fetches another maxscroll number of lines,
  even if fewer would suffice to fulfill the request:
  Start tog log.  jjjjj... down to the bottom of the screen and scroll
  a few lines further down.  Go back to the first entry.  Now page
  down and see the entry count.

I don't know if these even qualify as issues worth changing.

-- 
Christian "naddy" Weisgerber                          naddy@mips.inka.de