From: Stefan Sperling <stsp@stsp.name>
Subject: Re: commit.sh: brace expansion is not in POSIX
To: Christian Weisgerber <naddy@mips.inka.de>
Cc: gameoftrees@openbsd.org
Date: Wed, 16 Sep 2020 23:46:49 +0200

On Wed, Sep 16, 2020 at 11:00:03PM +0200, Christian Weisgerber wrote:
> Expand arguments in shell script since brace expansion is not in POSIX.
> 
> I'm pretending to ask for an ok, but in reality I'm sneakily reminding
> you all that brace expansion is a ksh extension. ;-)

Oh, is it? I keep learning a lot from these diffs :)

Ok.

> 
> diff 9439a9901031adbd5c05fec5a5f692144bb3fd53 /home/naddy/got
> blob - afd416223df26a16e6b2f6a618074947883e44e3
> file + regress/cmdline/commit.sh
> --- regress/cmdline/commit.sh
> +++ regress/cmdline/commit.sh
> @@ -248,7 +248,8 @@ test_commit_deleted_subdirs() {
>  		return 1
>  	fi
>  
> -	(cd $testroot/wt && got rm -R $testroot/wt/{epsilon,gamma} >/dev/null)
> +	(cd $testroot/wt && \
> +		got rm -R $testroot/wt/epsilon $testroot/wt/gamma >/dev/null)
>  
>  	(cd $testroot/wt && got commit -m 'test commit_deleted_subdirs' \
>  		> $testroot/stdout 2> $testroot/stderr)
> -- 
> Christian "naddy" Weisgerber                          naddy@mips.inka.de
> 
>