From: Stefan Sperling <stsp@stsp.name>
Subject: Re: Add missing <sys/types.h> to lib/utf8.c
To: Christian Weisgerber <naddy@mips.inka.de>
Cc: gameoftrees@openbsd.org
Date: Sat, 19 Sep 2020 20:40:20 +0200

On Sat, Sep 19, 2020 at 04:27:49PM +0200, Christian Weisgerber wrote:
> Another micro patch...
> 
> Add missing <sys/types.h> include.
> 
> lib/utf8.c includes got_error.h, which uses uint32_t when declaring
> got_error_uuid().  However, there is no preceding explicit include
> for <sys/types.h>.  On OpenBSD it just happens to be pulled in by
> some other system header.
> 
> ok?

Yes please.

As far as I'm concerned you can just go ahead with committing any such
header include fixes you need, without going through this list first.

> diff 6c13dcd2d0d730f9f9fc0fb0c42eb0f409216063 /home/naddy/got
> blob - 41c3f2e47158bafbf6229ab2c3b32dbb106c2e93
> file + lib/utf8.c
> --- lib/utf8.c
> +++ lib/utf8.c
> @@ -15,6 +15,8 @@
>   * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
>   */
>  
> +#include <sys/types.h>
> +
>  #include <err.h>
>  #include <stdlib.h>
>  #include <string.h>
> -- 
> Christian "naddy" Weisgerber                          naddy@mips.inka.de
> 
>