From: Christian Weisgerber <naddy@mips.inka.de>
Subject: Re: got_repo_map_path()
To: gameoftrees@openbsd.org
Date: Thu, 22 Oct 2020 18:03:39 +0200

Stefan Sperling:

> I think good a first step towards clearing up the confusion is to
> avoid calling got_repo_map_path() if we have a work tree. We can
> trivially derive the in-repository path from an in-work-tree path.
> 
> The following patch does this for 'got log'. Other commands are also

That looks sensible.

> affected and could be fixed in a similar way. The patch even fixes

log, blame, tree; tog
"blame" and "tree" don't call got_worktree_resolve_path().

> a bug where 'got log' run without any arguments in a work tree with
> a path prefix will only show changes within that path prefix. I think
> this should only happen if the user explicitly specified a path, such
> as the current directory (via "."). If no path is specified 'got log'
> should always log the root path and thus all commits on the branch.

Hmm.  If you say so.  It feels surprising to me, but that's old
CVS/SVN thinking, I guess.

-- 
Christian "naddy" Weisgerber                          naddy@mips.inka.de