From: Stefan Sperling <stsp@stsp.name>
Subject: Re: tog: trim log_scroll_*, trigger_log_thread functions
To: Christian Weisgerber <naddy@mips.inka.de>
Cc: gameoftrees@openbsd.org
Date: Tue, 1 Dec 2020 23:30:36 +0100

On Tue, Dec 01, 2020 at 11:13:12PM +0100, Christian Weisgerber wrote:
> Stefan Sperling:
> 
> > > -scroll_up(struct tog_view *view,
> > > -    struct commit_queue_entry **first_displayed_entry, int maxscroll,
> > > -    struct commit_queue *commits)
> > > +log_scroll_up(struct tog_view *view, int maxscroll)
> > 
> > Any reason you are not passing a struct tog_log_view_state parameter here
> > instead of struct tog_view? Is it for consistency with log_scroll_down()?
> 
> For consistency, yes.
> In fact, all of {log,ref,tree}_scroll_{up,down} now take a view
> parameter, but log_scroll_down() is the only one that needs it.
> For the others, the view state would suffice.

Ah, I see. Fair enough then.

> > If so, I don't think there's a problem with these function taking different
> > types for their first parameters. log_scroll_down() can be special.
> 
> I'm happy to change the others to take a state parameter if you
> prefer.
> 

Uhmm... Let's wait with that until all your other diffs are through :-O