From: Stefan Sperling <stsp@stsp.name>
Subject: Re: tog log: request more commits when window expands
To: Christian Weisgerber <naddy@mips.inka.de>
Cc: gameoftrees@openbsd.org
Date: Wed, 2 Dec 2020 14:49:43 +0100

On Wed, Dec 02, 2020 at 01:56:17PM +0100, Christian Weisgerber wrote:
> Start tog log in a window.  Then make the window taller.  The added
> lines remain empty.  tog will add more commits when you move down,
> but it doesn't happen automatically.
> 
> The log view should request more commits when the window is enlarged
> and there aren't enough to fill the new lines.
> 
> Adding the fragment below, pinched from log_scroll_down(), fixes
> this.
> 
> ok?

Yes, great! ok

> diff 3e13595003634037ff26696ce7a32545721bfc24 /home/naddy/got
> blob - dcec3b8db7f80bdbe871e35ab38c736bbfb705f6
> file + tog/tog.c
> --- tog/tog.c
> +++ tog/tog.c
> @@ -2409,10 +2409,16 @@ input_log_view(struct tog_view **new_view, struct tog_
>  	case KEY_RESIZE:
>  		if (s->selected > view->nlines - 2)
>  			s->selected = view->nlines - 2;
>  		if (s->selected > s->commits.ncommits - 1)
>  			s->selected = s->commits.ncommits - 1;
> +		if (s->commits.ncommits < view->nlines - 1 &&
> +		    !s->thread_args.log_complete) {
> +			s->thread_args.commits_needed += (view->nlines - 1) -
> +			    s->commits.ncommits;
> +			err = trigger_log_thread(view, 1);
> +		}
>  		break;
>  	case KEY_ENTER:
>  	case ' ':
>  	case '\r':
>  		if (s->selected_entry == NULL)
> -- 
> Christian "naddy" Weisgerber                          naddy@mips.inka.de
> 
>