From: Stefan Sperling Subject: Re: tog: ref view must pass selected reference name to log view To: Christian Weisgerber Cc: gameoftrees@openbsd.org Date: Fri, 4 Dec 2020 22:42:48 +0100 On Fri, Dec 04, 2020 at 05:38:01PM +0100, Christian Weisgerber wrote: > Stefan Sperling: > > > This patch is about hitting Enter on a reference displayed in a ref > > view, which will open a log view for the corresponding branch/tag. > > > > The log view needs to told the name of the selected reference. Otherwise, > > keys such as Ctrl-L and B will load the branch pointed to by HEAD instead > > of staying in the selected branch/tag. > > Yes, although that state is currently unreachable since a log view > opened from a ref view will self-destruct on ^L or B. Yes :) > I think your fix is incomplete, log_tree_entry() has the same > problem. I'd rather fix that separately because the tree view doesn't store a reference name at all right now.